search

Swirrl / csv2rdf

Clojure library and command line application for converting CSV to RDF. An implementation of the W3C CSVW specifications
Eclipse Public License 1.0
27 stars 6 forks source link

Fix logging configuration #325

Closed lkitching closed 1 year ago

lkitching commented 1 year ago

Issue #322 - Warnings are not being displayed because the log configuration no longer works.

The SLF44 API was updated to version 2, which now uses the service provider API to locate logging implementations. Bindings which target the 1.7 API are ignored.

Change the log4j binding implementation to log4j-slf4j2-impl which target version 2 of the SLF4J API.

Update the build-app task in build.clj to include the resources of the with-logging profile which includes the log4j2.xml configuration file.

RickMoynihan commented 1 year ago

The PR looks good, but as discussed elsewhere I think we should close this PR and do this work on the almost ready for merging #319 PR; as the GraalVM work essentially removes log4j.

I think we'll need a mechanism for API users to bring their own logger... something like what is described here:

https://github.com/Swirrl/csv2rdf/pull/319#issuecomment-1460546060