SwissDataScienceCenter / amalthea

A kubernetes operator for spawning and exposing interactive user session servers.
Apache License 2.0
14 stars 4 forks source link

feat: single sidecars exe and versioned templates #745

Closed olevski closed 1 month ago

olevski commented 1 month ago

There are a few things that happen here:

This later part about "versioned templating" is required to prevent the following scenario:

There are other reasons too. For example we upgrade the version of the sidecar image but its api has changed. Then either new sessions with the new sidecar work or the old ones are patched restarted but now when they start back up they keep crashing because the sidecars image API has changed.

olevski commented 1 month ago

It's looking good however I am just not sure about what "template" refers to in this context.

There's the fact that these are template functions but in the k8s context, some resources such as deployment uses template in the sense of "reference pod declaration to be used when creating pods".

In this case "template" means the real k8s children resources I generate from the CR specification. I.e. the PVC, Ingress, Service, Statefulset, etc.

olevski commented 1 month ago

This change is part of the following stack:

Change managed by git-spice.