Add Support for Sylius 1.12

Sylius / ShopApiPlugin

Shop API for Sylius.

https://sylius.com

130 stars 89 forks source link

Add Support for Sylius 1.12 #734

Closed TheMilek closed 1 year ago

TheMilek commented 1 year ago

Changes:

Dropped symfony/web-server-bundle as is no longer supported by Symfony
Bumped up the phpstan/phpstan to 1.8 version and phpstan/phpstan-webmozart-assert to 1.2
Updated .env.dist files to make them usable with the available documentation

Important! To potential merge after merging https://github.com/Sylius/ShopApiPlugin/pull/735 and https://github.com/Sylius/ShopApiPlugin/pull/737

TheMilek commented 1 year ago

Thanks for the work you put in to get this plugin up to speed.

I just have one two things: Would you mind summarizing in a comment what requirements have changed. I see there is no longer support for Symfony 4, we also dropped Sylius 1.10 anything I missed? Furthermore, do we need a change log entry for the upgrade or should it continue to work out of the box?

Hi @mamazu! Yeah it should work out of the box, also with these updated .env files the steps in the Readme file are the same. I updated the description with the changes as You requested 💃🏽. The continuation of this PR is here where I also add SF6 support

mamazu commented 1 year ago

@TheMilek That's great. Then I'll merge it. Never mind. Hubkit isn't working. Can you merge it?

TheMilek commented 1 year ago

@mamazu I just let know my teammates from Sylius 😄

GSadee commented 1 year ago

Thank you, Kamil! :tada: