search

SynDaverCO / symple-slicer

A web-based slicer for 3D printers using the Cura Engine
GNU Affero General Public License v3.0
21 stars 9 forks source link

0% infill not being recognized #182

Closed synsuiter closed 2 years ago

synsuiter commented 2 years ago

Describe the bug Unable to Slice with 0% infill.

Details

To Reproduce Steps to reproduce the behavior:

  1. Open SS
  2. Load model and any profile
  3. set the infill % to 0
  4. Slice
  5. You will see it is at a higher % than 0.

Expected behavior It should accept 0% infill.

Screenshots 0percent-infill_001 0percent-infill_002

marciot commented 2 years ago

The "Infill Density" (infill_sparse_density) only indirectly controls the infill via the "Infill Line Distance" (infill_line_distance) setting. If no "infill_line_distance" was specified in the profile, then changing the "infill_sparse_density" would cause "infill_line_distance" to recompute, and thus the model would be changed appropriately. However, because the profile is setting "infill_line_distance" to be a certain value, changing "infill_sparse_density" has no effect. The user would need to change "infill_line_distance"

This is because as it stands, any values explicitly set in the profile will be blocked from being automatically recomputed based on other values. If you do not think this is appropriate, we could eliminate that requirement. It's just unclear as to what really makes sense, so I had to make decision one way of another.

marciot commented 2 years ago

As it stands right now, it is important that profiles only change one setting along a dependency chain. If more than one setting along that chain is set in the profile, then the user will not get the results they might expect if they change the setting which is higher in the chain.

synsuiter commented 2 years ago

Ahh yeah, this makes sense and I can can update some of the profile stuff to correct this. I will close this out