search

SyneRBI / SIRF-SuperBuild

SIRF CMake SuperBuild
http://www.ccpsynerbi.ac.uk
Apache License 2.0
15 stars 18 forks source link

provide Brewfiles #424

Closed KrisThielemans closed 2 years ago

KrisThielemans commented 4 years ago

I've just learned that you can provide a file listing brew dependencies. This can be used with brew bundle --global apparently. As I'm not a brew user, I have no idea if this is a good thing to do, but it is listed on the Travis doc, see here.

It would certainly simplify people's life, and our Travis file(s). It might resolve some Travis problems, such as #753, as the Travis doc says

The Homebrew addon correctly handles up-to-date, outdated, and missing packages. Manual Homebrew dependency scripts are error-prone, and we recommend against using them.

A difficulty would be how to manage the various brew dependencies for each package. Ideally, SIRF would have its own Brewfile for instance, and the SuperBuild would use that. However, that seems hard to do, as brew would need to be called before the SuperBuild cmake, let alone make, and hence it won't have the SIRF source yet. My suggestion would be to have a separate folder with a bunch of Brewfiles (for the projects that we know what it should be).

A further difficulty would be if we want to test the superbuild USE_SYSTEM*=OFF without installing brew packages, but I'd be fine with not testing that option anymore for OSX.

Note that the first difficulty is the same as for Python requirements.txt files , see also #92

KrisThielemans commented 2 years ago

I think we shouldn't do this. Already too much on our plate. Contributions welcome.