SynologyOpenSource / minimalPkg

Example package for synology toolkit framework - MIT License (MIT)
MIT License
27 stars 5 forks source link

missing line in minimalPkg.c #1

Closed biloucat closed 8 years ago

biloucat commented 8 years ago

the line ret = sysinfo(&info); is missing in minimalPkg.c why "EXEC= minimalPkg_2 in Makefile ??? should not be EXEC= minimalPkg ???

SynologyOpenSource commented 8 years ago

Thanks for your reply.

We will add ret = sysinfo(&info); into minimalPkg.c. Sorry for make this mistake.

In pkgscripts framework, we can cross-compile source code by

  1. Makefile + include /env.mak
  2. SynoBuildConf/build We need to demonstrate above two scripts in minimalPkg. In build script SynoBuildConf/build, we compile the minimalPkg first and then execute command make ${MAKE_FLAG}. If Makefile still uses minimalPkg as executable name, make ${MAKE_FLAG} will not really compile the binary. So we change the example executable name to minimalPkg_2 so that make ${MAKE_FLAG} will use the cross-compiler to compile the source.

In order to avoid other user confusing the executable name, we will adjust executable name and add the comment before it.

biloucat commented 8 years ago

Thanks, but who to contact to update the developer guide ?

SynologyOpenSource commented 8 years ago

Thanks for your reply.

We will update the developer guide later.