search

Synthetixio / synthetix-v3

MIT License
116 stars 56 forks source link

Fix the unrecognized custom error issue in tests (probably hardhat error) #273

Open leomassazza opened 2 years ago

leomassazza commented 2 years ago

And remove the extra check in assert-revert.js when is fixed

Related to https://github.com/nomiclabs/hardhat/issues/1996

theethernaut commented 2 years ago

Checked if this was fixed today, but seems like not yet. I asked to bump the priority tho.

theethernaut commented 2 years ago

Had another look at this today. Still, no fixes from hh it seems.

Opened a PR to be a bit more explicit: https://github.com/Synthetixio/synthetix-v3/pull/667

The problem still seems to be that the first time tests are run errors are not parsed, but runs fine the second time.