search

SynthstromAudible / DelugeFirmware

https://synthstromaudible.github.io/DelugeFirmware/
GNU General Public License v3.0
568 stars 97 forks source link

Incoming non-MPE polyphonic aftertouch events not being recognized by Deluge without prior note-on events #2203

Open percussijan opened 4 months ago

percussijan commented 4 months ago

Please describe the problem:

Sending/receiving normal (non-MPE) polyphonic aftertouch from/to an external MIDI instrument through Deluge results in unwanted behavior: Modulations get "stuck" and the external device is not playable/recordable as intended.

What is the expected behavior?

Deluge recognises non MPE poly-aftertouch events without them needed to be attached to a prior note-on event .

As m-m-adams stated on Discord: Non-MPE poly aftertouch events could perhaps bypass MPE handling and go straight to the right note row .

Is there a relevant Pull request?

no

What hardware did you reproduce it with?

OLED

What firmware did you reproduce it with?

other

What is the firmware name:

community 1.1 RC4

If possible provide the steps to reproduce the issue and upload additional media:

This issue occurs while using Roland HPD-20 Percussion Pad and Yamaha FGDP Finger Drum Pads

m-m-adams commented 4 months ago

Gameplan is to put poly after touch (not mpe) directly in the respective note row, and have it count as the previous note for note shifting purposes