Error in minimizing protein pool usage

SysBioChalmers / GECKO

Toolbox for including enzyme constraints on a genome-scale model.

http://sysbiochalmers.github.io/GECKO/

MIT License

66 stars 51 forks source link

Error in minimizing protein pool usage #287

Closed Yu-sysbio closed 1 year ago

Yu-sysbio commented 1 year ago

https://github.com/SysBioChalmers/GECKO/blob/70b93d33aa5aefddeef2957c355046534a6b1ee6/protocol.m#L237

Should it be 1? The flux of prot_pool_exchange is negative.

ae-tafur commented 1 year ago

Yes, now flux is negative it must be positive

edkerk commented 1 year ago

Solved in 05df8105e61da016fb4d224834c7f1be0e914f97

Yu-sysbio commented 1 year ago

Solved in 05df810

Actually there are a few lines containing -1 that should be corrected in the protocol.m file. And let's keep in mind correcting this in the protocol manuscript.