Closed edkerk closed 1 year ago
This PR has been automatically tested with GH Actions. Here is the output of the tests:
[Warning: Cannot find RAVEN Toolbox in the MATLAB path, or the version is too old (before v2.8.3). Make sure you have installed RAVEN in accordance to the following instructions,
including running 'checkInstallation()': https://github.com/SysBioChalmers/RAVEN/wiki/Installation]
[> In GECKOInstaller.checkRAVENversion (line 77)
In GECKOInstaller.install (line 13)]
Note: In the case of multiple test runs, this post will be edited.
I was about to get started on the light Human-GEM but it looks like you've had some great progress. I'll happily review this when ready.
- distribute a modified human-GEM 1.15.0 in yml format
I want to remember a discussion around providing ec models as part of this repository - that this should either be avoided, or restricted to a couple of exceptions; I couldn't find this written down anywhere though.
Some other notes:
tutorials/
to start with tutorial_
to strongly underline that these are examples and should not be treated as "production-ready", i.e., not used as-is in research
- distribute a modified human-GEM 1.15.0 in yml format
I want to remember a discussion around providing ec models as part of this repository - that this should either be avoided, or restricted to a couple of exceptions; I couldn't find this written down anywhere though.
This is to have a functional tutorial, the discussion was whether we should distribute production-ready/curated ecModels, but for that we'll use the ecModels
repo.
Some other notes:
- this PR will resolve part of protocol for ecEcoli, and GECKO light protocol for Human-GEM #314
- my preference is for all subfolders of
tutorials/
to start withtutorial_
to strongly underline that these are examples and should not be treated as "production-ready", i.e., not used as-is in research
To this aim, I removed yeast-GEM
and human-GEM
from the tutorial names and folders. IMHO, adding tutorial_
will not have a drastic impact, more important would be to mention the non-production-ready state in the protocol.m
and model adapter files. This can probably be strengthened (particularly in model adapter).
The two protocols are not fully finished yet, but already significant changes have been made while updating the protocols upto this point.
Requires ~RAVEN 2.8.2~ RAVEN develop
at the moment, as will be checked when running GECKOInstaller.install
. Will be updated to 2.8.3 with next GECKO release.
I am beginning to review this PR.
My review of the light model is finished - I'll re-review once the final part of the protocol is finished. There are some comments for the full version of the tutorial. Once those are resolved I will also have a go through that tutorial.
Main improvements in this PR:
full_ecModel
andlight_ecModel
full_ecModel
:plotCrabtree
makes plot that demonstrates Crabtree effect in ecModelsplotlightVSfull
makes plot comparing flux distribution in light and full ecModelslight_ecModel
:uniprotConversion.tsv
andspontaneousReactions.tsv
as derived from files on the Human-GEM GitHub repository, to avoid dependency on having that repo installed. SeeHumanGEMAdapter
with explanation on how the files were obtained.reportEnzymeUsage
can make report of top-10 used enzymes.loadConventionalGEM
can loadyaml
model files.enzymeUsage
reports as positive values.flexibilizeProtConcs
also keeps track of the ratio of protein concentration change.fillProtConcs
allows for selection of column fromprotData
, if it contains multiple datasets.setKcatForReactions
can directly modify a kcat for all associated reactions, useful for manual curation on existing ecModels.getReactionsFromEnzyme
gives which reactions are catalyzed by a particular enzyme, from a provided Uniprot ID.ecFVA
goes through the correct list of mapped reactions and deals with failing simulations.ModelAdapterManager
does not save ecModel paths to the MATLAB path, as this would be persistent.~Note: #320 should be merged to
develop
before this PR.~ done.I hereby confirm that I have:
develop
as a target branch (top left drop-down menu)