SysBioChalmers / GECKO

Toolbox for including enzyme constraints on a genome-scale model.
http://sysbiochalmers.github.io/GECKO/
MIT License
66 stars 51 forks source link

feat: updates related to tutorials #319

Closed edkerk closed 1 year ago

edkerk commented 1 year ago

Main improvements in this PR:

~Note: #320 should be merged to develop before this PR.~ done.

I hereby confirm that I have:

github-actions[bot] commented 1 year ago

This PR has been automatically tested with GH Actions. Here is the output of the tests:

 
[Warning: Cannot find RAVEN Toolbox in the MATLAB path, or the version is too old (before v2.8.3). Make sure you have installed RAVEN in accordance to the following instructions,
including running 'checkInstallation()': https://github.com/SysBioChalmers/RAVEN/wiki/Installation]
[> In GECKOInstaller.checkRAVENversion (line 77)
In GECKOInstaller.install (line 13)]

Note: In the case of multiple test runs, this post will be edited.

mihai-sysbio commented 1 year ago

I was about to get started on the light Human-GEM but it looks like you've had some great progress. I'll happily review this when ready.

mihai-sysbio commented 1 year ago
  • distribute a modified human-GEM 1.15.0 in yml format

I want to remember a discussion around providing ec models as part of this repository - that this should either be avoided, or restricted to a couple of exceptions; I couldn't find this written down anywhere though.

Some other notes:

edkerk commented 1 year ago
  • distribute a modified human-GEM 1.15.0 in yml format

I want to remember a discussion around providing ec models as part of this repository - that this should either be avoided, or restricted to a couple of exceptions; I couldn't find this written down anywhere though.

This is to have a functional tutorial, the discussion was whether we should distribute production-ready/curated ecModels, but for that we'll use the ecModels repo.

Some other notes:

To this aim, I removed yeast-GEM and human-GEM from the tutorial names and folders. IMHO, adding tutorial_ will not have a drastic impact, more important would be to mention the non-production-ready state in the protocol.m and model adapter files. This can probably be strengthened (particularly in model adapter).

edkerk commented 1 year ago

The two protocols are not fully finished yet, but already significant changes have been made while updating the protocols upto this point.

Requires ~RAVEN 2.8.2~ RAVEN develop at the moment, as will be checked when running GECKOInstaller.install. Will be updated to 2.8.3 with next GECKO release.

mihai-sysbio commented 1 year ago

I am beginning to review this PR.

mihai-sysbio commented 1 year ago

My review of the light model is finished - I'll re-review once the final part of the protocol is finished. There are some comments for the full version of the tutorial. Once those are resolved I will also have a go through that tutorial.