SysBioChalmers / Mouse-GEM

Genome-scale model for Mus musculus
Creative Commons Attribution 4.0 International
7 stars 5 forks source link

Fix: only annotate model before SBML export #18

Closed JonathanRob closed 1 year ago

JonathanRob commented 1 year ago

Main improvements in this PR:

Many of the model annotation fields added to the model by the annotateGEM function are non-standard and therefore can cause problems with many functions (see Issue #16). However, the function is helpful for adding the annotation information into the SBML file.

This PR re-orders the final steps of the masterScriptMouseGEM.m function to add the annotation information to the model after the .mat and .yml formats have been written, but before writing the SBML model format.

Note: this change should also be made in the other Animal GEM repos.

I hereby confirm that I have:

JonathanRob commented 1 year ago

@haowang-bioinfo after merging the changes into develop for each of the Animal-GEMs, should I go ahead and merge develop into main, re-run the master script, and commit the updated models to main?

Also, I see that the version field of these models is empty. Should I leave it empty, or update it to the next version (I suggest this is a patch, so +0.0.1 to current version)? I can then try to make a release for each, unless you want to do that.

haowang-bioinfo commented 1 year ago

@haowang-bioinfo after merging the changes into develop for each of the Animal-GEMs, should I go ahead and merge develop into main, re-run the master script, and commit the updated models to main?

yes, go ahead - check the previous commits as references.

Also, I see that the version field of these models is empty. Should I leave it empty, or update it to the next version (I suggest this is a patch, so +0.0.1 to current version)? I can then try to make a release for each, unless you want to do that.

patch is good