search

Syxton / moodle-block_massaction

THE OFFICIAL Mass Actions block for Moodle 3.9 and beyond
9 stars 14 forks source link

Issue #81 No failure during duplicate and write error into event #90

Closed TomoTsuyuki closed 10 months ago

TomoTsuyuki commented 1 year ago

Implemented to avoid error in the middle of duplication. #81 Event "massaction_duplicated" has been introduced for the logging.

image

dmitriim commented 1 year ago

Thanks @TomoTsuyuki for working on it. The code looks good in general. I have seen people copping hundreds of activities. I'm a bit worried how that all will look at the logs screen. I have left my comments.

Also the patch covers just duplicate, what about duplicate_to_course?

TomoTsuyuki commented 1 year ago

Thanks @TomoTsuyuki for working on it. The code looks good in general. I have seen people copping hundreds of activities. I'm a bit worried how that all will look at the logs screen. I have left my comments.

Also the patch covers just duplicate, what about duplicate_to_course?

Thanks for your review @dmitriim I updated the events and support duplicate_to_course.

Please let me know if they are ok.

Syxton commented 1 year ago

@TomoTsuyuki I'm sorry for all the delays on these proposed fixes. I had to make some decisions on the future direction of the plugin. We have made a fairly major change moving forward in 4.2+ so these changes and the ones in the other PR's will need rebased to the latest master commits. Also, when making these requests, please do not make changes to the version.php and I will alter the version number once we have integrated changes. That way we don't have constant conflicts on version numbers. I understand that for testing the version number might need tweaked to add new settings, lang strings, etc. Again sorry to send you back to development on all this work. Your time invested is really valued. Thank you.

TomoTsuyuki commented 1 year ago

Hi @Syxton ,

Thanks for your comment. I rebased my branch with master, and removed the version.php from the commit. Are you accepting PRs for the new MOODLE_401_STABLE branch? If you will maintain only master branch, we need to make our fork to update the MOODLE_401_STABLE branch as our clients are using 4.1 LTS.

Syxton commented 1 year ago

@TomoTsuyuki The 4.1 branch still works on 4.2 and 4.3, so I will of course still accept PR's that improve and extend the lifespan of that version of the plugin. Just create another PR for the sub 4.2 changes and submit against MOODLE_401_STABLE

TomoTsuyuki commented 1 year ago

Thanks @Syxton , that's good news. I made PRs for 401 branches. Please review and let me know if I need to do extra work.