search

Szpadel / chrome-headless-render-pdf

223 stars 67 forks source link

Allow setting custom chrome options #24

Closed dudeofawesome closed 6 years ago

dudeofawesome commented 6 years ago

Headless Chrome in Travis CI only works with sandboxing disabled, so I needed to a way to set that option with this module.

I added a --chrome-option argument which can be used multiple times to create an array of options that get added to the commandLineOptions array.

I've currently got a working version of this published on NPM at @dudeofawesome/chrome-headless-render-pdf.

dudeofawesome commented 6 years ago

@Szpadel I believe I've addressed all of your points now.

I'm not super thrilled with the description I've got for how to use the new chrome-option flag, so if you've got something better, I'll change it for sure.