Wait until page load to set virtual time budget

Szpadel / chrome-headless-render-pdf

223 stars 67 forks source link

Wait until page load to set virtual time budget #30

Closed wioux closed 6 years ago

wioux commented 6 years ago

This branch waits until after the page load event fires to set the JS time budget. This fixes an intermittent problem I see where the CLI appears to hang after connecting to Chrome and logging the "Opening [url]" line (more details in #29).

Szpadel commented 6 years ago

Fixed in 7517a3dfa84fce858bbf8b6f170a746af6933093 But thanks for PR, it was helpful for debugging