search

Szpadel / chrome-headless-render-pdf

223 stars 67 forks source link

Adds support for displayHeaderFooter, headerTemplate and footerTemplate #41

Closed Eitz closed 3 years ago

Eitz commented 6 years ago

What do you think? Can you test it in your environment?

I don't know exactly how it would work for multiple PDF, tbh.

This PR closes #40

Szpadel commented 6 years ago

do you know from with chrome version this option is available?

Eitz commented 6 years ago

Whoops, I did some commits that I thought wouldn't be included in the pull request. Sorry about that.

About the version, I really don't know.

Prinzhorn commented 5 years ago

I'd love to see this supported. @Eitz could you please fix the PR? E.g. you used tabs for indentation while the project seems to use spaces.

Eitz commented 5 years ago

Hi @Prinzhorn.

Sorry, I won't be able to fix it as I am in the process of moving out of the country so I am kind of out of time here, maybe in a month or two 😆.

Other than the tabs vs spaces I think this PR is solid as we've been using it for a while in production with no problems. Feel free to fix it and then propose another PR if you need, but I think @Szpadel wants to test in multiple versions before merging.

bartvanhoutte commented 5 years ago

Would be awesome!

KasparEtter commented 4 years ago

@Szpadel: I would really like to have this functionality. Can I help with this in any way? Would you accept a new, clean PR for this?

Szpadel commented 4 years ago

I currently do not have much time, but if there will be PR good to merge, I will accept that

Eitz commented 4 years ago

Hi @Szpadel, I've done the long waited clean up for this branch and rebased on master.

You might wanna test it again as it's been a long time since I used this lib.