Add ability to pass extra arguments to Chrome

[ghost]

This patch will add the ability to pass desirable options like --no-sandbox and --incognito to the command line options

[Szpadel]

Thank you for this PR!

I would like to wait first for #8, #6 because if we really need to use spawn then using string with all arguments isn't convenient. I'm thinking about passing multiple arguments in this way: --extra-chrome-arg=--no-sandbox --extra-chrome-arg=--force-device-scale-factor=4 This would create array with arguments what could be then just concatenated with existing arguments.

[ghost]

It's your project, so you can do what you like with it. With respect, the way I passed in the extra arguments is standard practice and cleaner.

[Szpadel]

This isn't really just personal preference, but I see here technical challenge.

I had to switch chrome spawn method to spawn and this method expects arguments passed as array. This means that we are then responsible for splitting it on our own. This isn't that easy as splitting it by space character, because you may need to pass space is chrome argument sth, like: --some-arg="some param", split would create in this case 2 arguments --some-arg="some and param" that aren't correct to chrome. Escape sequences like \" wont also work now.

Therefore I see 2 possible options

• use some kind of regexp to split arguments based on -- (but this may be problematic when you will need to pass those in additional argument)
• pass arguments multiple times one by one (like in previous post) (maybe also remove second -- would make it more clear? like --extra-chrome-arg=no-sandbox)

If you find any better solution I'm open to change my mind :)

[ghost]

I noticed that change. I actually think this will still work as the surrounding string essentially makes --extra-arguments one argument. I'm testing this assumption right now.

[ghost]

Nevermind. It seems to not like it. Not sure why exactly. I'm working on a different solution now...