TAMULib / SAGE

Search Aggregation Engine
MIT License
6 stars 2 forks source link

Improve defined/undefined/null handling in specific cases. #478

Open kaladay opened 1 year ago

kaladay commented 1 year ago

Is your feature request related to a problem? Please describe. While investigating #476, I found that there were a number of places that could have more precise checking.

I added those checks during the investigation but was able to solve the problem without them. I removed those changes rather than having a more complicated hotfix in the PR. This is a follow up to utilize the code (or something similar) that has a more aggressive or precise sanity checking in the area where I noticed the problem.

Describe the solution you'd like Example solution:

Describe alternatives you've considered We could just leave the code alone as-is. There are currently no observed problems.

jcreel commented 1 year ago

Our aim should be to document a local standard for treating the problematic behavior of bivalent logic in Javascript. Thanks to Kevin for getting the ball rolling.