This is a quick fix for improving unsubscribe behavior.
This is not a complete fix for #428 .
This does not bother with trying to determine a good name for the subscriptions.
This re-uses the existing shared subscription array, making appropriate changes to make this possible.
A better design approach is preferred, but I consider this an acceptable quick fix.
Anywhere the shared store is not used and can be avoided, an ngOnDestroy() is called directly with the appropriate .unsubscribe(); call.
These changes appear to significantly reduce the impact of the problem.
I do not believe these changes alone solve the problem.
I believe this design approach can be greatly improved upon.
This is a quick fix for improving unsubscribe behavior. This is not a complete fix for #428 .
This does not bother with trying to determine a good name for the subscriptions.
This re-uses the existing shared subscription array, making appropriate changes to make this possible. A better design approach is preferred, but I consider this an acceptable quick fix.
Anywhere the shared store is not used and can be avoided, an
ngOnDestroy()is called directly with the appropriate.unsubscribe();call.These changes appear to significantly reduce the impact of the problem. I do not believe these changes alone solve the problem. I believe this design approach can be greatly improved upon.