search

TASEmulators / BizHawk

BizHawk is a multi-system emulator written in C#. BizHawk provides nice features for casual gamers such as full screen, and joypad support in addition to full rerecording and debugging tools for all system cores.
http://tasvideos.org/BizHawk.html
Other
2.2k stars 385 forks source link

[F.Rq.] Expose Genplus-gx' built-in NTSC filter #3977

Closed ghost closed 4 months ago

ghost commented 4 months ago

Gensplus-gx expose built in ntsc filter

I believe its as simple as exposing and makes some titles much better

CasualPokePlayer commented 4 months ago

It's not as simple as exposing, it's simply not supported for our configuration (using 32bpp rendering, the NTSC filter is only supported for 15bpp or 16bpp rendering).

YoshiRulz commented 4 months ago

I was already thinking of closing this since our (unwritten) policy is not to use upstream's filters/upscaling/"goodizers".

CasualPokePlayer commented 4 months ago

An NTSC filter isn't really a "goodizer," it's more akin to color correction options (if not just what the NES palette options just do)

Granted, an NTSC filter can probably be made into some generic shader if anything.

YoshiRulz commented 4 months ago

So this is a duplicate of #3391?

vadosnaprimer commented 4 months ago

I was already thinking of closing this since our (unwritten) policy is not to use upstream's filters/upscaling/"goodizers".

There's no such policy.

nattthebear commented 4 months ago

Please don't duplicate an issue after you didn't get the answer you wanted the first time (https://github.com/TASEmulators/BizHawk/issues/3672).

There's no such policy.

There kind of is; why waste time adding a core specific post-process when the same work could be used to add something that would work on all cores?

vadosnaprimer commented 3 months ago

why waste time adding a core specific post-process when the same work could be used to add something that would work on all cores?

Because the shader way is almost unusable, since libretro shaders that have those features won't run on hawk. So per-core options seem to be the only way for regular users who can't port RA shaders to hawk (or fix hawk to support then, which would absolutely solve this the right way, obviously).

ghost commented 3 months ago

Was simply asking for the same treatment as the a7800 core dunno why everyone against it but ok

ghost commented 3 months ago

Isint this as simple as just allowing the user to turn orn the filter already in gens plus gx?? Why block it on purpose i dont understand

CasualPokePlayer commented 3 months ago

It's not as simple as exposing, it's simply not supported for our configuration (using 32bpp rendering, the NTSC filter is only supported for 15bpp or 16bpp rendering).

nattthebear commented 3 months ago

Because the shader way is almost unusable, since libretro shaders that have those features won't run on hawk. So per-core options seem to be the only way for regular users who can't port RA shaders to hawk (or fix hawk to support then, which would absolutely solve this the right way, obviously).

I'm comparing developer time working on this one core vs developer time spent on the frontend, so the comparison would be with improving RA shader support or adding some other method to do this in the frontend.