search

TASEmulators / BizHawk

BizHawk is a multi-system emulator written in C#. BizHawk provides nice features for casual gamers such as full screen, and joypad support in addition to full rerecording and debugging tools for all system cores.
http://tasvideos.org/BizHawk.html
Other
2.2k stars 385 forks source link

Disk Drive Activity LED ToolTip enhancement #4022

Closed Asnivor closed 2 months ago

Asnivor commented 2 months ago

A number of cores are using the IDriveLight interface, but many of them aren't using it for disk drive activity. We have disks, CDs, carts and other things hooked up.

This PR adds a DriveLightIconDescription string to the IDriveLight interface, allowing for cores to set their own ToolTip on the drive light icon.

I was planning on using a default implementation in the interface (so that cores didn't have to explicitly set a value and we could use the default), but it looks like this might require a higher version of C#.

Thoughts?

Check if completed:

Asnivor commented 2 months ago

It feels like we could do something better here. Being able to instantiate multiple activity lights on by-core basis, all with custom tooltips and even different icons. Being able to have separate LEDs for disk, tape, CD or whatever might be quite a nice improvement, rather than ramming lots of things down into one indicator.

I'm just not entirely sure how to implement it yet.

YoshiRulz commented 2 months ago

Fixed on master as 6d05b9874c3dc7d0946055d3181745294c447267 and rebased this onto that.