search

TASEmulators / BizHawk

BizHawk is a multi-system emulator written in C#. BizHawk provides nice features for casual gamers such as full screen, and joypad support in addition to full rerecording and debugging tools for all system cores.
http://tasvideos.org/BizHawk.html
Other
2.2k stars 385 forks source link

[Genesis Plus GX] Pixel aspect ratio not accounted for in "Use system's recommendation" Display config #4042

Open badgertapes opened 2 months ago

badgertapes commented 2 months ago

When "Use system's recommendation" is enabled, all Genesis Plus GX games still display in a 1:1 pixel aspect ratio, regardless of system or region setting. Forcing the games to run at 4:3 under "Use custom AR" provides a good enough facsimile, though I have to manually disable it for when I play games using other systems and cores. The libretro docs website lists aspect ratio options under Core-Provided Aspect Ratio [genesis_plus_gx_aspect_ratio]

2.10 dev at e56830549

CasualPokePlayer commented 2 months ago

libretro would have nothing to do with BizHawk's port of GPGX, that is just something specific to their port.

GPGX for us just never had some PAR correction put in place (although it'd probably be trivial to take whatever libretro does I guess). Probably because the display without PAR correction is already close to 4:3 anyways, so it wasn't considered a priority.

Morilli commented 2 months ago

I've tried to fix this and while doing so read into what the correct aspect ratio is, and apparently it depends on the video mode (H40 vs H32 at least, but apparently there's also V28/V30 modes which probably matter?), the system clock rate (which in itself depends on the region), and then of course the VDP mode.

Considering that video modes are never checked and instead either 256x192 or 320x224 is hardcoded as base aspect ratio on core startup, I would say there is more to do to properly handle all of this.