PUAE FFI enums use implicit values

TASEmulators / BizHawk

BizHawk is a multi-system emulator written in C#. BizHawk provides nice features for casual gamers such as full screen, and joypad support in addition to full rerecording and debugging tools for all system cores.

http://tasvideos.org/BizHawk.html

Other

2.2k stars 385 forks source link

PUAE FFI enums use implicit values #4110

Closed YoshiRulz closed 6 days ago

YoshiRulz commented 1 week ago

Also "unplugged" / no peripheral is missing. https://github.com/TASEmulators/BizHawk/blob/c7d87c487e015a3f8f97747c88ec4fe92144c670/src/BizHawk.Emulation.Cores/Computers/Amiga/LibPUAE.cs#L76-L89

Setting explicit values should be required in general, at least for enums used in wbox/native interop.

vadosnaprimer commented 1 week ago

Also "unplugged" / no peripheral is missing.

Which games require it?

vadosnaprimer commented 6 days ago

So zero info about games that need unplugged.

Also I'm not convinced someone working an a core would just randomly forget to update enums on one side while changing them on the other without any testing. MOST cores use enums with implicit values, so I have no idea why puae is being singled out here.