search

TBD54566975 / dwn-sdk-js

Decentralized Web Node (DWN) Reference implementation
https://identity.foundation/decentralized-web-node/spec/
Apache License 2.0
326 stars 105 forks source link

Return 204 when there is no data #790

Closed andresuribe87 closed 3 months ago

andresuribe87 commented 3 months ago

Fixes #695

Additionally, changes the scripts.test value so that source maps are correct and point to the actual implementation files instead of the transpiled JS files.

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.69%. Comparing base (bb09ebe) to head (9599803).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #790 +/- ## ======================================= Coverage 98.69% 98.69% ======================================= Files 73 73 Lines 11264 11269 +5 Branches 1609 1612 +3 ======================================= + Hits 11117 11122 +5 Misses 141 141 Partials 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

andresuribe87 commented 3 months ago

@LiranCohen ready for review. Would appreciate some 👀 !

andresuribe87 commented 3 months ago

@LiranCohen is it cool to merge bypassing branch protections?

thehenrytsai commented 3 months ago

NOTE: The CVE was discovered in, and is being fixed by this PR waiting to be merged:

https://github.com/indutny/elliptic/pull/317

Therefore I am bypassing the branch protections for merging this.