TBog / TBLauncher

based on https://github.com/Neamar/KISS
GNU General Public License v3.0
133 stars 18 forks source link

Tag menu doesn't respond to changes in Apps tagged and to tag manager #477

Open DamageIncorporated opened 2 months ago

DamageIncorporated commented 2 months ago

Description

I am not sure if i am misunderstanding concepts here, but I try to describe what I expected:

Background: I tagged (too) many Apps with custom tags without thinking about it. The result was an overly cluttered tag menu. So I tried to remove redundant tags

Expected behaviour:

If I remove a specific tag from all apps, I would expect it to disappear from the "tag menu" which I can access from the dock

Same for the tag manager (which I had some trouble finding, but github issues said there was one): After removing tags from the manager, I would expect them to disappear from the tag menu.

Context

I use the app in german language , so my back-translation may contain errors

Steps to Reproduce

First approach:

  1. Open Apps Menu
  2. Long-Klick on any App that is already tagged
  3. select "Add tags"
  4. remove a specific tag
  5. repeat 1-4 for any app with the aforementioned specific tag
  6. Open the tag menu
  7. Error: See the specific tag in the list, that you just deleted everywhere
  8. tap on the specific tag (to make sure we didn't forget an app in 1-4)
  9. See an empty screen

Second approach: ... after finishing the first approach

  1. open tag-manager
  2. remove the specific tag
  3. Open the tag menu
  4. Error: See the specific tag in the list, that you just deleted for every app and in the tag manager
  5. tap on the specific tag (to make sure we didn't forget something above)
  6. See an empty screen

Expected behavior

In step 7. (first approach) but at least after step 2. (second approach) I would expect the specific tag to have disappeared from the tag menu.

Since I deleted it for every app and from the tag-manager, it's not relevant anymore.

Device info

TBog commented 2 months ago

Possible fix:

DamageIncorporated commented 2 months ago

closing/restarting the launcher didn't improve the situation...

I also restarted the phone several times for unrelated reasons in the mean time🤗

DamageIncorporated commented 2 months ago

I understand this behaviour is to be considered as a bug rather than user error?

if you @TBog would like me to help investigate this further, I'd need some assistance on how to get useful logs etc.

I'm technically fluent but have no experience using development tools besides following instructions to flash phones.

I generally like to help project devs where I can.

Alternatively I'd just reinstall, hope for the best 😅 and close this if the issue disappears afterwards.

Which variant would you prefer?

TBog commented 2 months ago

the tags manager displays under each tag the number of apps Screenshot_20240609_102510_rocks.tbog.tblauncher.debug.jpg

It should also allow you to remove the tag.

After I deleted the '18ctea' tag and pressed OK then reopened the tags manager this if how the menu looks

Screenshot_20240609_103115_rocks.tbog.tblauncher.debug.jpg

It seems like the bug did not happen in my case.

TBog commented 2 months ago

I think I missed the fact that you were trying to remove tags from the tag menu. To do that go to SettingsLayoutTags menu

Screenshot_20240609_104317_rocks.tbog.tblauncher.debug.jpg