TDAmeritrade / stumpy

STUMPY is a powerful and scalable Python library for modern time series analysis
https://stumpy.readthedocs.io/en/latest/
Other
3.68k stars 322 forks source link

Set notebook structure and implemented KTIP algorithm #1040

Closed joehiggi1758 closed 1 week ago

joehiggi1758 commented 1 month ago

Pull Request Checklist

Below is a simple checklist but please do not hesitate to ask for assistance!

review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.33%. Comparing base (9616686) to head (0f2766c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1040 +/- ## ======================================= Coverage 97.33% 97.33% ======================================= Files 89 89 Lines 15027 15027 ======================================= Hits 14626 14626 Misses 401 401 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

seanlaw commented 1 month ago

@joehiggi1758 I know that this is still a work-in-progress but this looks fantastic! I haven't gone over things in detail but, at a high level, I really like how you're breaking everything down in consumable chunks and also explaining each part very clearly. One thing I would like to ask is if can please cross-reference sections/figures/algorithms within the paper so something like:

The next step is to calculate the lower bound (see Section X.Y and Figures A-C)

This way, we can quickly find where things are within the original source.

Finally, please leave me a comment here when you think it is ready for any type of feedback or if you had any questions. Great job so far!

joehiggi1758 commented 2 weeks ago

@seanlaw hope you're having a great one!

I've been fairly busy with work lately, but still wanted to move this forward!

I'm about 85% there, the full MOMP implementation isn't working yet - but open to your feedback up to this point on the structure, breakdown and implementation of each sub function!

seanlaw commented 2 weeks ago

Thanks @joehiggi1758 and no problem on any delays. Please allow me some time to review it and provide feedback.

seanlaw commented 1 week ago

Moved to #1046