Closed seanlaw closed 4 months ago
Need to add ray
example to docstrings
Attention: Patch coverage is 20.21277%
with 225 lines
in your changes missing coverage. Please review.
Project coverage is 97.42%. Comparing base (
f8f245c
) to head (8af81d0
). Report is 51 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
tests/test_ray.py | 38.18% | 68 Missing :warning: |
stumpy/stumped.py | 6.52% | 43 Missing :warning: |
stumpy/aamped.py | 2.77% | 35 Missing :warning: |
stumpy/mstumped.py | 10.52% | 34 Missing :warning: |
stumpy/maamped.py | 11.76% | 30 Missing :warning: |
ray_python_version.py | 0.00% | 10 Missing :warning: |
stumpy/core.py | 37.50% | 5 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@NimaSarajpoor I think this is ready to be reviewed (I know you are super busy so no rush). Please feel free to ask any questions as I'm sure I missed many things since I've stared at it for so long :)
@NimaSarajpoor I've made some changes based on your suggestions
Btw, I was wondering if you would like to update the README as well
No, since it is experimental, I would consider adding it in the future IF ray
(and numpy
, scipy
, and numba
too) has no issues after 2-3 version updates.
This should be my last set of comments! That was one big PR with huge amount of effort you put behind it!
@NimaSarajpoor Please feel free to squash and merge if you feel that it is ready. Everything looks good on my part. Thank you for your help!
@seanlaw Done! (Thanks for the challenge!)
See #772
Pull Request Checklist
Below is a simple checklist but please do not hesitate to ask for assistance!
black
(i.e.,python -m pip install black
orconda install -c conda-forge black
)flake8
(i.e.,python -m pip install flake8
orconda install -c conda-forge flake8
)pytest-cov
(i.e.,python -m pip install pytest-cov
orconda install -c conda-forge pytest-cov
)black .
in the root stumpy directoryflake8 .
in the root stumpy directory./setup.sh && ./test.sh
in the root stumpy directory