search

TDRA-ae / aegov-dls

The UAE Design System version 2.0 presents a manual for federal government entities (FGEs) of the United Arab Emirates to plan and arrange content on their websites with simplicity and creativity.
https://designsystem.gov.ae
MIT License
25 stars 6 forks source link

[BUG] Does not use passive listeners to improve scrolling performance #67

Closed Sa7aR-Kassem closed 5 days ago

Sa7aR-Kassem commented 1 week ago

Take a moment to review - is it really a bug? Or is it more of an enhancement or a typo in the documentation? A Bug is code that is broken, or when you try to implement a certain piece of code that is mentioned in the documentation, you have a result that is not the same as described.

Now if you are absolutely sure it is indeed a bug, please fill in the following template.

Mention what part of the design system the bug is related to Is the bug part of a "Component", a "Block", the "Plugin" itself or something else? Ideally, your choice has to be one of the 3 items.

More context in relation to the design system If the bug is part of a component or a block, please mention which one. If the bug is related to the plugin, please mention if it is during installation, compiling or configuration.

Describe the bug A clear and concise description of what the bug is. Help us understand what you are doing that is causing an error.

To Reproduce Steps to reproduce the behaviour:

  1. Use chrome lighthouse tool
  2. Analysis the page
  3. Report has an error does not use passive listeners to improve scrolling performance
  4. Consider marking your touch and wheel event listeners as passive to improve your page's scroll performance designsystem.min.js. Learn more about adopting passive event listeners.

Expected behaviour A clear and concise description of what you expected to happen.

A bit more context about the browser

Additional context Add any other context about the problem here.

moiz-conceptlz commented 1 week ago

@Sa7aR-Kassem

Are you sure you are testing Lighthouse for your website in an incognito mode, and there are no chrome plugins added?

Are you referring to the JS code of aegov-scripts or to the custom code that you have added?

Passive listeners as a warning or error would be added to "Best Practices" section of Lighthouse. I'm attaching a screenshot of a website in incognito mode, with no chrome plugins added, tested from within the UAE, using version 2.2.5 of the design system. There is no such reported issue of Passive Listeners.

Screenshot 2024-11-20 at 10 17 11 AM
moiz-conceptlz commented 5 days ago

Closing this as this is not a bug