TEAMMATES / teammates

This is the project website for the TEAMMATES feedback management tool for education
https://teammatesv4.appspot.com/
GNU General Public License v2.0
1.67k stars 3.3k forks source link

Refactoring of sortable tables #12329

Open weiquu opened 1 year ago

weiquu commented 1 year ago

Sortable tables are used in several pages, but a fair number of them don't make use of the sortable-table component. Searching sortable amongst .html files should bring up these 10 (unlikely to be more, but best to do a more thorough search):

It would be good to refactor the above components to make use of the sortable-table component to avoid duplication. Some other components, like the contribution question statistics component and the MCQ question statistic component, already make use of that component, so they can be referenced.

Sho-Shoo commented 1 year ago

Hi! I would like to take this issue as a first-time contributor.

weiquu commented 1 year ago

Hi @Sho-Shoo, we normally recommend issues tagged with good first issue for first-time contributors. However, if you're confident of tackling this issue, you can go ahead and submit a PR for it (:

mud1tx commented 1 year ago

@weiquu Can you please describe the issue once again, I can work on this issue. One more thing what does sortable-table component do?

weiquu commented 1 year ago

Hi @mud1tx, you can find the sortable-table component files and look through them to see what they do and how they do it. As an overview, the sortable-table component, as the name suggests, is a sortable table. Do let me know if you run into any specific issues, and also detail your understanding and what you've tried so that I can better assist.

mud1tx commented 1 year ago

Hi @mud1tx, you can find the sortable-table component files and look through them to see what they do and how they do it. As an overview, the sortable-table component, as the name suggests, is a sortable table. Do let me know if you run into any specific issues, and also detail your understanding and what you've tried so that I can better assist.

I will try working on it today and let you know about it.

Zxun2 commented 1 year ago

Hello! I will like to try refactoring the sessions table component. Is that okay?

domlimm commented 1 year ago

@Zxun2 Hello! Feel free to submit a PR 👍🏻

singhabhyudita commented 1 year ago

Hi, I'll be taking up the Instructor courses page. Hope that's okay?

weiquu commented 1 year ago

Hi, I'll be taking up the Instructor courses page. Hope that's okay?

Sure, do note the changes to the sortable-table component that was introduced in #12501

domoberzin commented 1 year ago

Helllo, could I work on the student list component?

jasonqiu212 commented 1 year ago

Helllo, could I work on the student list component?

Sure thing @domoberzin :) Do note the changes introduced by #12501

RohithSurya commented 1 year ago

Hi Guys!! Letting you know I am working on refactoring notification tables 🙂.

domoberzin commented 10 months ago

Hi, just checking if this issue should be re-opened? Because the remaining subtasks have not yet been completed for the other pages

weiquu commented 10 months ago

Thanks @domoberzin! Good catch

Surge747 commented 1 month ago

Hey I would like to work on this refactoring Issue as a first time contributor I am an ANU student and as part of coursework we were assigned as a team to contribute to open source projects issues like this one I noticed this issue had a help wanted and has been stale for a while

Could I be assigned to work on it? Cheers Madhav Krishnan