TRAIS-Lab / dattri

`dattri` is a PyTorch library for developing, benchmarking, and deploying efficient data attribution algorithms.
https://trais-lab.github.io/dattri/
24 stars 8 forks source link

[dattri.func] Re-define Arnoldi algorithm as a projection method #100

Closed tingwl0122 closed 1 month ago

tingwl0122 commented 1 month ago

Description

1. Motivation and Context

Originally, Arnoldi algorithm is defined as one of the ihvp method in dattri/func/ihvp.py, but funcitonal-wise, it is closer to a projection method with approximation on the inverse-Hessian. Thus, we move it to dattri/func/projection.py.

2. Summary of the change

3. What tests have been added/updated for the change?

tingwl0122 commented 1 month ago

The projector LGTM, so we still need another PR to make this support IFAttributorArnoldi right?

Yes, or do you think it is better to include that in this PR?

tingwl0122 commented 1 month ago

The projector LGTM, so we still need another PR to make this support IFAttributorArnoldi right?

Yes, or do you think it is better to include that in this PR?

probably not, I will do this in the next PR.

tingwl0122 commented 1 month ago

Closed since commit history is too messy, a new PR (#108) will replace this.