Closed tingwl0122 closed 1 month ago
The projector LGTM, so we still need another PR to make this support
IFAttributorArnoldi
right?
Yes, or do you think it is better to include that in this PR?
The projector LGTM, so we still need another PR to make this support
IFAttributorArnoldi
right?Yes, or do you think it is better to include that in this PR?
probably not, I will do this in the next PR.
Closed since commit history is too messy, a new PR (#108) will replace this.
Description
1. Motivation and Context
Originally, Arnoldi algorithm is defined as one of the ihvp method in
dattri/func/ihvp.py
, but funcitonal-wise, it is closer to a projection method with approximation on the inverse-Hessian. Thus, we move it todattri/func/projection.py
.2. Summary of the change
dattri/func/random_projection.py
asdattri/func/projection.py
ArnoldiProjector
to take care of the Arnoldi algorithm.3. What tests have been added/updated for the change?