TRAIS-Lab / dattri

`dattri` is a PyTorch library for developing, benchmarking, and deploying efficient data attribution algorithms.
https://trais-lab.github.io/dattri/
24 stars 8 forks source link

[dattri.func.ihvp] Implement ihvp_at_x_ekfac #94

Closed sx-liu closed 2 months ago

sx-liu commented 2 months ago

Description

1. Motivation and Context

This PR is the same as the closed one #79.

To complete the proposal in the issue #76.

2. Summary of the change

The implementation is basically the same as originally designed.

Specifically,

3. What tests have been added/updated for the change?

sx-liu commented 2 months ago

Seems like test_ihvp_datainf_nn is a bit shaky.

jiaqima commented 2 months ago

Seems like test_ihvp_datainf_nn is a bit shaky.

Could lower the threshold to 0.8.

sx-liu commented 2 months ago

Seems like test_ihvp_datainf_nn is a bit shaky.

Could lower the threshold to 0.8.

Should I do it here or in a separate PR?

jiaqima commented 2 months ago

Seems like test_ihvp_datainf_nn is a bit shaky.

Could lower the threshold to 0.8.

Should I do it here or in a separate PR?

You could just do it here. This shaky test is going to block other PRs if we merge this PR without lowering the threshold.