search

TREX-CoE / trexio

TREX I/O library
https://trex-coe.github.io/trexio/
BSD 3-Clause "New" or "Revised" License
49 stars 14 forks source link

Versioning of python packages #120

Closed scemama closed 1 year ago

scemama commented 1 year ago

Please do not forget to update the Python API version when you change it in configure/CMakeLists

I really think that having two different version numbers for C/Fortran and Python is extremely confusing. If we tell users to get version 2.3.2 of the library, they will automatically do pip install trexio-2.3.2 and will get it wrong. It adds an extra layer of complexity.

As the Python package is distributed with the C library in a single repo, I think we should really have a common version number.

q-posev commented 1 year ago

I am sure that most of the time the users do pip install trexio without pinning the version :-)

The motivation to have them different was to allow patches in the Python API which do not affect C/Fortran. For example, recent bug with the loss of precision when reading float numbers was fixed purely on the Python side and this was reflected in the bump of Python patch version, without touching the C library. For me personally it would be more confusing to see a change in a C library version only because of the Python API.

You can sync both C and Python API versions if you want.

scemama commented 1 year ago

I will do it from version 2.4.0 :partying_face: