Currently the test script is defined as npm run lint && npm run useChrome && npm run build. Every time a developer will run npm run test they will automatically also run npm run useChrome. On linux this will override the existing manifest.json therefore making it extremely annoying to keep the Firefox manifest. This should not be the default behavior for a test.
I also changed the workflow from implicitly using the chrome manifest through the npm run test command to explicitly using the chrome config.
Typescript
I created the PR because this projects uses typescript but those typescript files never actually get checked. For example the filesrc/contentScripts/other/hisqis/newTable.ts will throw a error on Line 113 if you run tsc.
With this PR every time the test script gets run it will additionally do a typescript check through the tsc --noEmit command. This also means that the test script will fail locally and in CI when a typescript error is detected.
Type of change
[ ] Bug fix (non-breaking change which fixes a bug)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that might cause existing functionality to not work as expected)
[x] Testing scripts
Further info
[ ] This change requires a documentation update
[ ] I updated the documentation accordingly, if required
Description
NPM test script
Currently the
test
script is defined asnpm run lint && npm run useChrome && npm run build
. Every time a developer will runnpm run test
they will automatically also runnpm run useChrome
. On linux this will override the existingmanifest.json
therefore making it extremely annoying to keep the Firefox manifest. This should not be the default behavior for a test. I also changed the workflow from implicitly using the chrome manifest through thenpm run test
command to explicitly using the chrome config.Typescript
I created the PR because this projects uses typescript but those typescript files never actually get checked. For example the file
src/contentScripts/other/hisqis/newTable.ts
will throw a error on Line 113 if you run tsc. With this PR every time the test script gets run it will additionally do a typescript check through thetsc --noEmit
command. This also means that the test script will fail locally and in CI when a typescript error is detected.Type of change
Further info
Testing
npm run test
locally