TUfast-TUD / TUfast_TUD

Browser Extension for higher productivity with TU Dresden IT-Services 🚀
https://www.tu-fast.de
GNU General Public License v3.0
37 stars 12 forks source link

Fix/npm test #139

Closed A-K-O-R-A closed 7 months ago

A-K-O-R-A commented 8 months ago

Description

NPM test script

Currently the test script is defined as npm run lint && npm run useChrome && npm run build. Every time a developer will run npm run test they will automatically also run npm run useChrome. On linux this will override the existing manifest.json therefore making it extremely annoying to keep the Firefox manifest. This should not be the default behavior for a test. I also changed the workflow from implicitly using the chrome manifest through the npm run test command to explicitly using the chrome config.

Typescript

I created the PR because this projects uses typescript but those typescript files never actually get checked. For example the file src/contentScripts/other/hisqis/newTable.ts will throw a error on Line 113 if you run tsc. With this PR every time the test script gets run it will additionally do a typescript check through the tsc --noEmit command. This also means that the test script will fail locally and in CI when a typescript error is detected.

Type of change

Further info

Testing