search

TabularEditor / BestPracticeRules

An official collection of standard Rules for use with Tabular Editor's Best Practice Analyzer.
122 stars 53 forks source link

camelCase rule is causing false positives on PascalCasing #54

Closed alxdean closed 1 year ago

alxdean commented 1 year ago

The Rule "Avoid CamelCase on visible measures and tables" (BPA-Standard) is checking for the first letter being upper case. That would be PascalCasing and not camelCasing. in camelCasing the first letter is lower case.

otykier commented 1 year ago

You're right. The name of the rule should be "Avoid PascalCase on visible measures and tables".

alxdean commented 1 year ago

We'll, that woukd be the correct name for the regex, but I don't agree. I find PascalCase a better standard for visible tables and measures :-)

If fixing anything, then the Regex should be fixed to match the rule :-)

On Wed, 1 Mar 2023, 14:38 Daniel Otykier, @.***> wrote:

You're right. The name of the rule should be "Avoid PascalCase on visible measures and tables".

— Reply to this email directly, view it on GitHub https://github.com/TabularEditor/BestPracticeRules/issues/54#issuecomment-1450167404, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3M3QIJESQKNNL4YEJINQ3WZ5GMXANCNFSM6AAAAAAVMB4YOM . You are receiving this because you authored the thread.Message ID: @.***>

otykier commented 1 year ago

The rules are mostly inspired by this article. The good news is, however, that you are free to customize and change them anyway you see fit :)