The image does not move with the button when I press a PressableButton

TakeScoop / SwiftyButton

Simple and customizable button in Swift

MIT License

553 stars 43 forks source link

The image does not move with the button when I press a PressableButton #14

Open Sweeper777 opened 7 years ago

Sweeper777 commented 7 years ago

To reproduce this, put a PressableButton on the storyboard, set its image to some image and text to "". Now try to press the button. The button will look like as if it's been pressed, but the image stays at the same position. This looks very unnatural.

ldiqual commented 6 years ago

Oh good point, we haven't implemented image inset changes in the pressed state. Will tackle soon.

ldiqual commented 6 years ago

@Sweeper777 Fixed in https://github.com/TakeScoop/SwiftyButton/commit/f9ec59a5456e2a2ad6b8e26b86c7adb6293c05d0 which I merged in master. Would you mind giving it a shot with Cocoapods?

pod 'SwiftyButton', :git => 'git@github.com:TakeScoop/SwiftyButton.git', :branch => 'master'

Sweeper777 commented 6 years ago

I can't seem to install the pod. This is the error:

Also, is this for Swift 3? My old project is still using Swift 3.