search

TarikHuber / material-ui-responsive-drawer

Material-UI responsive Drawer is a React-Redux component that uses Material-UI to create a responsive Drawer.
MIT License
43 stars 18 forks source link

Remove the muiThemable import from BodyContainer and ResponsiveAppBar #1

Closed karmajunkie closed 7 years ago

karmajunkie commented 7 years ago

The muiThemable import isn't used anywhere I can see, and prevents the component from being used with the next branch on material-ui. This PR just removes the reference so it can be used.

TarikHuber commented 7 years ago

Released Version 1.1.14 to npm with this PR

karmajunkie commented 7 years ago

Awesome, thanks for merging it in!

One thing though, when I use the new version I'm still seeing the error in the code in the es directory: 

Module not found: Error: Can't resolve 'material-ui/styles/muiThemeable' in '/Users/keith/bidlily/api/node_modules/material-ui-responsive-drawer/es'
 @ ./~/material-ui-responsive-drawer/es/BodyContainer.js 13:0-59
 @ ./~/material-ui-responsive-drawer/es/index.js
 @ ./web/static/js/app-redux.js
 @ ./web/static/js/app.js

I'm not really a fulltime JS dev, did I forget a step in the PR?

TarikHuber commented 7 years ago

Forgot to build after PR ;) Please try again with 1.1.15 Sorry for the mistake.