search

Tarsnap / spiped

Spiped is a utility for creating symmetrically encrypted and authenticated pipes between socket addresses.
http://www.tarsnap.com/spiped.html
Other
858 stars 56 forks source link

tests/pushbits: add warning about EOF on stdin #321

Closed gperciva closed 3 years ago

gperciva commented 3 years ago

I don't know if we want to include this warning or not.

This issue cost me a few hours when working on pthread_create_blocking(), because my test case was based on echo_stdin_stdout() and I thought that the thread's non-existence was a problem with the creation code. It took me a while to discover that read(STDIN_FILENO, ...) was giving me an EOF when running in github actions but not on my own systems (virtualized or not).

gperciva commented 3 years ago

Also, even if we want to include the warning, the final paragraph of the commit message is rather less formal than the previous paragraphs, so you might prefer that to be rewritten or omitted. I figured it was useful info to include while you were evaluating this.

gperciva commented 3 years ago

Rebased, ready for merge.