Tasshack / dreame-vacuum

Home Assistant integration for Dreame robot vacuums with map support
https://community.home-assistant.io/t/custom-component-dreame-vacuum
MIT License
905 stars 113 forks source link

Added Swedish translation to Github fork #532

Closed jockebq closed 5 months ago

jockebq commented 6 months ago

Hi,

I'm not very good with GitHub, but I forked your project and added Swedish translation (sv.json) to the dev-branch: https://github.com/jockebq/dreame-vacuum/tree/swedish-language-support

I think I did a pull request, but I don't know if this goes to you automatically.

Please add this in the next beta release.

Thank you!

Tasshack commented 6 months ago

You should create a pull request to this repo not yours but don't worry I have downloaded the language file from your repo and it will be added on the next Beta release. Thanks for the help.

Tasshack commented 5 months ago

Added. https://github.com/Tasshack/dreame-vacuum/releases/tag/v2.0.0b15

jockebq commented 5 months ago

Tried updating to Beta 15. But got this issue: Error while loading /config/custom_components/dreame_vacuum/translations/sv.json: unexpected character: line 133 column 11 (char 4369)

Cannot find anything wrong with that line?

Tasshack commented 5 months ago

That line had missing " at the and but I have fixed it on the release. You have probably still be using your version and not the file that I have commited.

jockebq commented 5 months ago

That line had missing " at the and but I have fixed it on the release. You have probably still be using your version and not the file that I have commited.

Nope, I am using the one you commited. Removed the integration completely, and installed it via Hacs, still get the error: Error while loading /config/custom_components/dreame_vacuum/translations/sv.json: unexpected character: line 133 column 11 (char 4369)

Tasshack commented 5 months ago

You are the one who created the file, why are you asking me? Please dont waste my time anymore.

jockebq commented 5 months ago

You are the one who created the file, why are you asking me? Please dont waste my time anymore.

I am sorry, just trying to help with translating the project. You can remove the file if you wish. I found out that there was a comma missing from line 132.

Tasshack commented 5 months ago

I can understand you are trying to help but it's not helping when you ask me to find your mistake.