CakePHP Upgrade to 4.x

[cblanken]

This isn't anywhere near complete, but I wanted to get the ball rolling on issue #3067 to upgrade to CakePHP 4.x since 3.x is EOL.

Progress

I've been following the CakePHP 4.0 Upgrade Guide. It has a few steps:

• [x] Update to the latest 3.x release
  • CakePHP 3.9 and 3.10 are API compatible with 3.8 so I just updated the dependencies, though someone with more experience on the project may want to take a look at the changelogs for 3.9 and 3.10 just to be sure they aren't going to introduce any subtle bugs. Nothing has come up in my testing thus far though.

    Edit: I've tried to match these to individual commits mostly, so it should be apparent where each deprecation is resolved, but this is a high-level overview of all deprecations that need attention.

• [x] Clear up all the deprecation warnings
  • [x] Setting $config is deprecated. Configurations files should instead return an array. See https://book.cakephp.org/3/en/appendices/3-0-migration-guide.html#configure
  • [x] Access to Helper::$request as a property is deprecated as of CakePHP 3.7. The getter Helper->getRequest() should be used instead. See https://book.cakephp.org/3/en/appendices/3-7-migration-guide.html#deprecations
  • [x] Request::param() is deprecated as of 3.4. Use Request::getParam() instead. See https://book.cakephp.org/3/en/appendices/3-4-migration-guide.html#request-response-deprecations
  • [x] Accessing params as a property will be removed in 4.0.0. Use request->getParam() instead See https://book.cakephp.org/3/en/appendices/3-4-migration-guide.html#request-response-deprecations.
  • [x] FormHelper::input() is deprecated. Use FormHelper::control() instead. See https://book.cakephp.org/3/en/appendices/3-4-migration-guide.html#other-deprecations.
  • [x] FormHelper::create() should take null instead of a string or bool as the context when creating contextless forms. See https://book.cakephp.org/3/en/appendices/3-9-migration-guide.html#deprecations.
  • [x] Cake\Controller\Component\SecurityComponent::config() is deprecated. Use setConfig()/getConfig() instead. I couldn't find the exact version this deprecation happens, but the SecurityComponent page here (https://book.cakephp.org/3/en/controllers/components/security.html) implies SecurityComponent::config() is deprecated after 3.4
  • [x] Using Query::repository() as getter is deprecated. Use getRepository() instead See https://book.cakephp.org/3/en/appendices/3-6-migration-guide.html#deprecations for details.
  • [x] EventManager::attach() is deprecated. Use EventManager::on() instead See https://api.cakephp.org/3.0/class-Cake.Event.EventManager.html
  • [x] parseNamedParams() is deprecated
    • This has been borrowed from CakePHP 3.x to continue supporting named parameters.
  • [x] The ArrayAccess methods will be removed in 4.0.0. Use withParam() instead See https://book.cakephp.org/3/en/appendices/3-4-migration-guide.html
  • [x] Accessing data as a property will be removed in 4.0.0. Use request->getData() instead. See https://book.cakephp.org/3/en/appendices/3-4-migration-guide.html
  • [x] ViewBuilder::autoLayout() is deprecated. Use ViewBuilder::enableAutoLayout() or ViewBuilder::isAutoLayoutEnable() instead. See https://book.cakephp.org/3/en/appendices/3-4-migration-guide.html#deprecated-combined-get-set-methods
  • [x] Plugin::load() is deprecated. Use Application::addPlugin() instead. This method will be removed in 4.0.0 See https://book.cakephp.org/3/en/appendices/3-7-migration-guide.html#testsuite Note: there are only a few instances of this deprecation. Specifically in the tests, so I elected to use the TestCase::loadPlugins() method instead of Application::addPlugin().
  • [x] ExportsTable deprecations
    • ValidatorAwareTrait::validator() is deprecated. Use ValidatorAwareTrait::getValidator()/setValidator() instead. See https://book.cakephp.org/3/en/appendices/3-5-migration-guide.html#validation
    • App\Model\Entity\Export::errors() is deprecated. Use setError()/getError() or setErrors()/getErrors() instead. See https://github.com/cakephp/cakephp/blob/571fb867995ccfa4034ec5b66577f0ab2acd4429/src/Datasource/EntityInterface.php#L188
    • Validator::errors() is deprecated. Renamed to Validator::validate(). See https://book.cakephp.org/3/en/appendices/3-9-migration-guide.html#deprecations
    • App\Model\Table\ExportsTable::schema() is deprecated. Use setSchema()/getSchema() instead. See https://book.cakephp.org/3/en/appendices/3-4-migration-guide.html#deprecated-combined-get-set-methods
  • [x] Email::setTemplate() is deprecated. Use $email->viewBuilder()->setTemplate() instead. See https://book.cakephp.org/3/en/appendices/3-7-migration-guide.html#deprecations
  • [x] Response::header() is deprecated. Use withHeader(), getHeaderLine() and getHeaders() instead. See https://book.cakephp.org/3/en/appendices/3-4-migration-guide.html#request-response-deprecations
  • [x] Declaring fixtures in underscored format in TestCase::$fixtures is deprecated. See https://book.cakephp.org/3/en/appendices/3-7-migration-guide.html#deprecations
  • [x] App\Model\Entity\Sentence::dirty() is deprecated. Use setDirty()/isDirty() instead.
  • [x] App\Model\Entity\Vocable::dirty() is deprecated. Use setDirty()/isDirty() instead.
  • [x] App\Model\Entity\Sentence::errors() is deprecated. Use setError()/getError() or setErrors()/getErrors() instead.
  • Deprecations within vendor code
    • ~~Automatic prefixing of paths with APP by Response::file() and withFile() is deprecated. Use absolute paths instead. See https://book.cakephp.org/3/en/appendices/3-4-migration-guide.html#request-response-deprecations~~
    • ~~You are using a deprecated argument order for Cake\Validation\Validator::allowEmptyString. You should reverse the order of your when and message arguments so that they are message, when. See https://book.cakephp.org/3/en/appendices/3-8-migration-guide.html#deprecations~~
• [ ] Use the 4.0 Upgrade Tool/CLI
• [ ] Applying Rector Refactorings
• [ ] Update CakePHP Dependency (target: CakePHP 4.0.10)
  • Dependency targets
    • "dereuromark/cakephp-queue": "^5.4.0"
    • "markstory/asset_compress": "^4.0"
    • "cakephp/migrations": "^3.0.0"
    • "codekanzlei/cake-auth-actions": "^4.0.0-rc5"
    • "cakephp/bake": "^2.2"

Abandoned packages

There are several abandoned packages still in use even after meeting the above dependency targets. It might be better to resolve these in another PR, but I'll document them here just in case.

• Package flow/jsonpath is abandoned, you should avoid using it. Use softcreatr/jsonpath instead.
• Package patchwork/jsqueeze is abandoned, you should avoid using it. No replacement was suggested.
• Package laminas/laminas-zendframework-bridge is abandoned, you should avoid using it. No replacement was suggested.
• Package phpunit/php-token-stream is abandoned, you should avoid using it. No replacement was suggested.

Remaining Deprecation Warnings

The deprecations I listed seem to be the most prolific, but as far as I can tell I got all instances of each. There are few more though.

[Deprecated (16384)](javascript:void(0);): Router::parseNamedParams() is deprecated. 2.x backwards compatible named parameter support will be removed in 4.0 - /home/vagrant/Tatoeba/src/Controller/AppController.php, line: 136
 You can disable deprecation warnings by setting `Error.errorLevel` to `E_ALL & ~E_USER_DEPRECATED` in your config/app.php. [CORE/src/Core/functions.php, line 311]
[Deprecated (16384)](javascript:void(0);): ServerRequest::query() is deprecated. Use getQuery() or the PSR-7 getQueryParams() and withQueryParams() methods instead. - /home/vagrant/Tatoeba/src/Controller/SentencesController.php, line: 509
 You can disable deprecation warnings by setting `Error.errorLevel` to `E_ALL & ~E_USER_DEPRECATED` in your config/app.php. [CORE/src/Core/functions.php, line 311]
[Warning (512)](javascript:void(0);): Unable to emit headers. Headers sent in file=/home/vagrant/Tatoeba/vendor/cakephp/cakephp/src/Error/Debugger.php line=855 [CORE/src/Http/ResponseEmitter.php, line 53]
[Warning (2)](javascript:void(0);): Cannot modify header information - headers already sent by (output started at /home/vagrant/Tatoeba/vendor/cakephp/cakephp/src/Error/Debugger.php:855) [CORE/src/Http/ResponseEmitter.php, line 154]
[Warning (2)](javascript:void(0);): Cannot modify header information - headers already sent by (output started at /home/vagrant/Tatoeba/vendor/cakephp/cakephp/src/Error/Debugger.php:855) [CORE/src/Http/ResponseEmitter.php, line 183]
[Warning (2)](javascript:void(0);): Cannot modify header information - headers already sent by (output started at /home/vagrant/Tatoeba/vendor/cakephp/cakephp/src/Error/Debugger.php:855) [CORE/src/Http/ResponseEmitter.php, line 269]

The first one listed here in particular may be a bit troublesome. I'm not familiar with all the routing done for the application, but I assume named parameters are still in use for some routes, thus the invokation of parseNamedParams(). Unfortunately, it seems 4.0 and onward won't support them, so it may be necessary to write some custom middleware to handle whatever requests are still using named parameters.

This is still a work in progress, but I'll see what I can do about the remaining deprecation warnings to get the application ready to use the 4.0 upgrade tool.

[jiru]

What an ambitious PR! :open_mouth: Thank you for getting on with this task.

I assume named parameters are still in use for some routes

Named parameters used to be the default for CakePHP < 3. They were used on Tatoeba for every page before. For example, if you look at this old archived page, you can see the "next page" links have a /page:2 parameter (as opposed to ?page=2). CakePHP 3.x changed that default, we also did, but we did not want to break existing links, so just to keep backward compatibility we use parseNamedParams(). You can try opening https://tatoeba.org/fr/sentences_lists/show/724/page:2 and you’ll see it still brings you to page 2 (a redirect would have been better though :pensive:). That’s the only reason.

[cblanken]

(a redirect would have been better though 😔). That’s the only reason.

Do you think it'd be best to inline the parseNamedParams() function from CakePHP 3.x? Otherwise this might be a good opportunity to stop supporting named parameters. If someone with access to the server could check the logs, there may not even be any recent usage of links with named parameters. In that case it'd probably be best to remove completely since they won't be supported by CakePHP in the future.

[jiru]

As far as I know we only keep logs for a short time so they probably won't give a good overview of old links usage. To keep maintaining old links or not to and potentially break things, that is the question! Personally I'm in favor of keeping old links working as long as it's not a burden (which I don't think it is, I mean it's fine to keep our own copy of parseNamedParameters()). I don't think anybody likes getting 404 errors when browsing the web.

[cblanken]

Okay, I've done what I can with this, but I don't think I'm familiar enough with CakePHP to sort out what's remaining. I've documented the changes as well as I could with links to the appropriate migration guide pages.

Maybe I'll return to it once I've worked with the codebase a bit more, but for the time being, anyone else who wants to pick this up is welcome to it.

[!NOTE]
When advancing the application to 4.x with the upgrade tool, be aware that PHP 8.x is required to run the tool, even though 4.x applications only have a minimum requirement of PHP 7.2. For more details, see https://book.cakephp.org/4/en/appendices/4-0-upgrade-guide.html#upgrade-to-php-8-0.

[jiru]

Thank you very much for working on this, @cblanken!