search

Tauffer-Consulting / domino

User friendly and open source platform for workflow creation and monitoring
https://domino-workflows.io/
Apache License 2.0
152 stars 14 forks source link

Cannot add a piece from a private repository #220

Closed tdari closed 9 months ago

tdari commented 10 months ago

I have created a piece in a private repository and I provided an access token with required permissions to domino.

When I hit the add button nothing happens.

image

But REST service returns OK.

"GET /pieces-repositories/releases?source=github&path=tdari%2Fsense-pieces&workspace_id=1 HTTP/1.1" 200 OK

vinicvaz commented 10 months ago

Hey @tdari This request that is returning 200 is for the pieces repositoies releases list. The flow for adding a repository is the following:

  1. Get the list of that repository releases from github
  2. Get the selected release data and save it to domino database.

Could you please check if your repository has at least one released published to github? For example, the default piece repo has the latest release as 0.8.0. If you have a published released let me know and I'll dig into it. Thanks

tdari commented 10 months ago

Hey, @vinicvaz that makes sense. Now I can add it thank you. This issue might be translated into UI bug if you wish.

vinicvaz commented 10 months ago

Totally agree with you. We must warn the user that no releases were found for the requested repo. If you are interested in exploring Domino REST please feel free to send a PR to dev branch with this fix. Otherwise, I'll assign this issue to @nathan-vm

tdari commented 10 months ago

I'm still exploring the codebase but you can assign me if you have no time constraint.

vinicvaz commented 10 months ago

Nice. I'll assign to @nathan-vm, it should be a quick fix.

I don't want to interfere in your experience exploring Domino and its features. Please keep bringing all these feedback and issue reports, they are really valuable!