search

Tauffer-Consulting / domino

User friendly and open source platform for workflow creation and monitoring
https://domino-workflows.io/
Apache License 2.0
152 stars 14 forks source link

Feature - Workflow pieces sharing local network #290

Open vinicvaz opened 7 months ago

vinicvaz commented 7 months ago

What is the problem this feature will solve?

This discussion brought https://github.com/Tauffer-Consulting/domino/discussions/289#discussion-6555798 an interesting point about network communication between pieces. Imagine a scenario where you want to have an web API piece that listen to other pieces to do actions, currently this is not possible, but maybe we want that.

What is the feature you are proposing to solve the problem?

We should consider a way of creating virtual networks in workflow context so pieces in the same workflow can share information using the localhost network.

What alternatives have you considered?

We should extend DominoK8SOperator and DominoDockerOperator to access k8s and docker api, create the network at the run of the dag and attach to the pieces in the same workflow.

vinicvaz commented 7 months ago

@tdari @nathan-vm fyi

luiztauffer commented 7 months ago

could we create a base Piece wrapper (e.g. BaseApiPiece) that would handle the rules for security, etc?