search

TeXitoi / keyberon

A rust crate to create a pure rust keyboard firmware.
MIT License
1.08k stars 79 forks source link

Variable Naming: tap-hold vs. hold-tap #105

Closed dariogoetz closed 2 years ago

dariogoetz commented 2 years ago

There are inconsistencies with the tap-hold/hold-tap naming, e.g. it is called TapHoldTracker but the Action is called HoldTap and corresponding HoldTapConfig. Then the interval is called tap_hold_interval and the tracker is called tap_hold_tracker.

I suggest establishing a uniform naming scheme by fixing one of the variants and I would be happy to file a PR for one or the other versions.

TeXitoi commented 2 years ago

That's a feature: tap then hold to keep the tap action pressed.

dariogoetz commented 2 years ago

Ah, yes. You are right :) My bad.