Tealium / tagbridge

Use of this software is subject to the terms and conditions of the license agreement contained in the file titled "LICENSE.txt". Please read the license before downloading or using any of the files contained in this repository. By downloading or using any of these files, you are agreeing to be bound by and comply with the license agreement.
Other
2 stars 3 forks source link

Android sample doesn't work #14

Open atetc opened 4 years ago

atetc commented 4 years ago

I tried to launch Android sample app and discovered few issues:

  1. Old Gradle version, can't be builded by Android Studio:

    PM  Gradle sync failed: Support for builds using Gradle versions older than 2.6 was removed in tooling API version 5.0. You are currently using Gradle version 2.2.1. You should upgrade your Gradle build to use Gradle 2.6 or later.
    Possible solution:
    - Upgrade Gradle wrapper to 2.6 version and re-import the project
    Consult IDE log for more details (Help | Show Log) (2 s 868 ms)
  2. After upgrading Gradle to 5.6.4 and configuring project to the latest libraries it crashes with:

    2020-05-11 07:35:49.240 13326-13326/com.tealium.sampleapp E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.tealium.sampleapp, PID: 13326
    java.lang.RuntimeException: Unable to get provider com.google.android.gms.ads.MobileAdsInitProvider: java.lang.IllegalStateException: 
    
    ******************************************************************************
    * The Google Mobile Ads SDK was initialized incorrectly. AdMob publishers    *
    * should follow the instructions here:                                       *
    * https://googlemobileadssdk.page.link/admob-android-update-manifest         *
    * to add a valid App ID inside the AndroidManifest.                          *
    * Google Ad Manager publishers should follow instructions here:              *
    * https://googlemobileadssdk.page.link/ad-manager-android-update-manifest.   *
    ******************************************************************************

Screenshot_1589157360

Build configuration:

apply plugin: 'com.android.application'

android {
    compileSdkVersion 29
    buildToolsVersion "29.0.3"

    defaultConfig {
        applicationId "com.tealium.sampleapp"
        minSdkVersion 23
        targetSdkVersion 29
    }

    buildTypes {
        release {
            minifyEnabled false
            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.txt'
        }
    }
}

dependencies {
    implementation 'androidx.appcompat:appcompat:1.1.0'
    implementation 'com.google.android.gms:play-services-ads:19.1.0'
    implementation 'com.tealium:library:5.7.1'
}
  1. After fixing Ads crash using this guide app doesn't response in GoogleDFPRemoteCommand class onInvoke(Response response) method (and Second screen is blank)

It would be great if you will upgrade samples in this repository and add expected sample behavior to the description.

atetc commented 4 years ago

Also, there is missing documentation in integrations: https://docs.tealium.com/platforms/remote-commands/integrations/

craigrouse commented 4 years ago

@atetc Thank you for bringing this to our attention. As you may have noticed, this repo hasn't been updated for 5 years, and the code and the documentation is therefore not current, and doesn't work with any of our current SDKs. The Google DFP integration on this repo is not currently supported, and all code on this repo should be considered legacy code and not maintained. I have already been talking to your Tealium support engineer about this, and they are in the best position to help you with your issue. We will likely change this repo to become private, since none of the content is current, and this is clearly open to cause confusion. Our current list of officially supported Remote Command (a.k.a. Tagbridge) integrations are listed on the docs page you identified. Anything not listed there is not currently supported. Please speak to your Tealium account manager about your specific use case for this integration, and they will be able to help prioritize any updates that may be required. Thanks for your understanding.