search

Team-Half-and-Half / spirebooks

A financial projection and management decision tool made for Spire Hawaii.
MIT License
0 stars 0 forks source link

Review: 11 Dashboard.jsx and InputABS.jsx #172

Open caspascual opened 3 days ago

caspascual commented 3 days ago

Overview

Please pay attention too:

Review Branch

review-11

Files to review

Checklists

Due date

Monday, 11/25/2024

For more information

The review process is documented at: http://courses.ics.hawaii.edu/ics414s21/morea/review/reading-idpm-review.html

XavierBurt commented 3 days ago

Dashboard.jsx:

The constants for the table can probably be moved to another file

InputABS.jsx

Remove the commented out imports Use multi line comments instead of multiple single line comments (ex lines 21-25) There might be a better way to do the text field. Not sure honestly but it's a lot of long repeated code. Maybe can make a method?

samallari commented 3 days ago

Dashboard.jsx

InputABS.jsx

caspascual commented 3 days ago

Dashboard.jsx

L25-61: Design-09: Should move these functions into their own file in utilities.

InputABS.jsx

L64-158: Design-01: All text field use label={false} disabled, are we able to make this into a class in CSS to remove redundancy?

L18-19: Design-05: Don’t see any reason to keep these comments

L14, L21: Design-05: Stuff comments, remove.

L43. ESLINT-02: Remove stuff ID, make new ID for testcafe.

t-tirabassi commented 3 days ago

Dashboard.jsx:

Design-07: The container in the return statement could be made into a component and then imported into the dashboard page.

Design-09: The constants for the table could be moved into utilities to be reused.

InputABS.jsx:

Design-05: The commented out imports and constants should be removed. Other unnecessary comments throughout the code should also be removed.

REACT-01: Move all the text fields in the balance sheet form into its own component so that the code is more readable.

beydlern commented 3 days ago

Dashboard.jsx:

InputABS.jsx