search

Team-Remastered / End-Remastered-Forge

End Remastered overhauls the way players get to the End and makes the experience way more interesting for them by forcing them to fully explore the beautiful world of Minecraft.
https://www.curseforge.com/minecraft/mc-mods/endremastered
GNU Lesser General Public License v3.0
6 stars 9 forks source link

Add Quark Compat and Fix Eyes being useable via Offhand #75

Closed VoidLeech closed 4 months ago

VoidLeech commented 4 months ago

Issues Fixed

Fixes #74 Adds Quark Compat for the Cryptic Eye; Quark Oddities (built-in into Quark but only activated when the separate Oddities jar is present) replaces the enchanting table with the Matrix Enchanter, making the cryptic eye unobtainable. Fixes a typo in the en_us lang file.

Implementation Details

Bump Forge version used in build to 47.1.3 (what Quark is built against) Mixin into Quark's MatrixEnchantmentMenu; use existing code for determining if we should create an eye. Made into a utility to not duplicate the code. Added a Mixin Plugin so we only apply this mixin when Quark is present Mixin into EnderEyeItem to cancel usage there, instead of the events

Testing

Tested with and without Quark (1.20.1), server and client Tested without Quark (no version exists) for 1.20.2 and 1.20.4, client only

Jack-Bagel commented 4 months ago

Hey, I really appreciate the compat with Quark as well as the multiple fixes good job!

I wanted to know before I merge, I see that in the Ender Eye mixin, the useOn method doesn't have a check for if the targeted block is an end portal frame, I believe this could create incompatibility problems with mods that need to use the eye on some other blocks.

Other than that, everything looks pretty good.

VoidLeech commented 4 months ago

Hey, thanks for reviewing! With the vanilla logic in use, I believe useOn can only get called when there's an end portal frame being clicked, but that's indeed a compatibility concern if someone wants the eye used on other blocks and makes a corresponding mixin into use. I've added that check.

VoidLeech commented 4 months ago

Hi! Were you planning on releasing this soon, or is there holdup I might be able to help with?

Jack-Bagel commented 4 months ago

I've been quit a bit busy lately but I'll make a release as soon as possible!

VoidLeech commented 3 months ago

Hey! Saw you posted a new 1.21 release a couple days ago, hope I'm not too much of a bother to remind you of this, as you might've forgotten given that this is a different repo (:

Jack-Bagel commented 3 months ago

Hey, thanks for the reminder, I just released the new version on Curseforge and Modrinth!

VoidLeech commented 3 months ago

Awesome!