search

Team138Entropy / Entropy2020

Team 138 FIRST Robotics Infinite Recharge 2020
4 stars 0 forks source link

Integration #169

Closed joecaraccio closed 4 years ago

joecaraccio commented 4 years ago

@maxh65000 I just took a few moments from work to make sure we got these changes in. These are all the integration changes for the competition robot, as well as updates to the turret and vision system. There might be errors in it right now, I couldn't compile it. I just want to get your eyes on it and then merged in as soon as possible. We need to have all these changes tested and used tonight

maxh65000 commented 4 years ago

PIDRoller is stopping the build

joecaraccio commented 4 years ago

@maxh65000 fixed it. I added a voltage compensation mode which will hopefully allow stability of our shooting loop. Also the closed loop error of 0 was probably reallllllly hurting our stability.

All climber changes can be pulled out.

jhinspeter commented 4 years ago

Huh? "All climber changes can be pulled out." What do you mean by this?

Thanks,

Jay

On Thu, Mar 5, 2020 at 3:58 PM Joe Caraccio notifications@github.com wrote:

@maxh65000 https://github.com/maxh65000 fixed it. I added a voltage compensation mode which will hopefully allow stability of our shooting loop. Also the closed loop error of 0 was probably reallllllly hurting our stability.

All climber changes can be pulled out.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Team138Entropy/Entropy2020/pull/169?email_source=notifications&email_token=ABR4CQHMUWVMKC6MXV5XJPTRGAG7NA5CNFSM4LCR6T62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEN634ZY#issuecomment-595443303, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABR4CQEIG5PVAZD4ZMHOKD3RGAG7NANCNFSM4LCR6T6Q .

joecaraccio commented 4 years ago

In the context of pull request, don't include the climber changes from this branch into the master branch. We aren't overwriting your work.