search

TeamAOF / All-of-Fabric-7

Modpack containing the latest & best of Fabric on 1.20
41 stars 31 forks source link

Missing Shebang in serverstarter.sh #154

Closed DisruptionSystemsINC closed 9 months ago

DisruptionSystemsINC commented 9 months ago

The shebang (!#/bin/bash) is missing from the serverstarter.sh script in version 1.3.2

SubordinalBlue commented 9 months ago

Not strictly necessary in the general case of shell scripts, and in this case... [checks commit history...] hasn't been there in years.

Just pass the script as an argument to calling the shell: sh serverstarter.sh.

DisruptionSystemsINC commented 9 months ago

Not strictly necessary in the general case of shell scripts, and in this case... [checks commit history...] hasn't been there in years.

Just pass the script as an argument to calling the shell: sh serverstarter.sh.

This is less than optimal practice.

SubordinalBlue commented 9 months ago

Makes 0 difference, really.

Except this way, the script file does not need execute permission set.