Closed EmmanuelMess closed 2 years ago
Sounds fair.
Milestone v3.3.0 is complete. We release rc1 now on beta channel. Everyone agree?
Remember to release as beta for FDroid too
I'm voting +1 for rc1 too. But a little question: though not required, should #1325 be available with 3.3.0 too?
Oh, my bad. Didn't get a chance to test it yesterday, had planned for after coming back from work. Will test now.
Remember to release as beta for FDroid too
I don't know how to release as beta on FDroid. Tried in past, there's no concrete guide, so didn't succeed. See here
Sorry, nevermind then.
Think its time to release the beta to the Play Store and have the testers weigh in.
I get database downgrade fc in building release3.3.0 branch. Did you not pull #1262 to the branch @EmmanuelMess ? I think we approved in the PR to merge to 3.3.0 release.
I get database downgrade fc in building release3.3.0 branch. Did you not pull #1262 to the branch @EmmanuelMess ? I think we approved in the PR to merge to 3.3.0 release.
Has milestone 3.4.0, it is only addition.
Maybe we forgot to change milestone. See comments there.
On Sat 30 Jun, 2018, 4:30 PM Emmanuel, notifications@github.com wrote:
I get database downgrade fc in building release3.3.0 branch. Did you not pull #1262 https://github.com/TeamAmaze/AmazeFileManager/pull/1262 to the branch @EmmanuelMess https://github.com/EmmanuelMess ? I think we approved in the PR to merge to 3.3.0 release.
Has milestone 3.4.0.
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/TeamAmaze/AmazeFileManager/issues/1315#issuecomment-401533900, or mute the thread https://github.com/notifications/unsubscribe-auth/AE-FsLweSX4fMVGMsaK3M1SRSft_EEnTks5uB1phgaJpZM4U1UwY .
@EmmanuelMess please add commits to this PR, I think we can push this with v3.3.0 so let's not wait over these things.
And nobody answered (sorry, didn't see the comment).
So now you see it, please merge it to release 3.3.0 branch.
No, it is a feature, if you want a fix from in there, I can make a specific PR.
But we did agree for that feature to be shipped with v3.3.0
On Sun 1 Jul, 2018, 5:13 PM Emmanuel, notifications@github.com wrote:
No, it is a feature, if you want a fix from in there, I can make a specific PR.
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/TeamAmaze/AmazeFileManager/issues/1315#issuecomment-401601353, or mute the thread https://github.com/notifications/unsubscribe-auth/AE-FsNqhT8qQ3-e6bcmGYBqaeVwMmTRcks5uCLXZgaJpZM4U1UwY .
But we did agree for that feature to be shipped with v3.3.0
Where? As I tell you I only saw:
@EmmanuelMess please add commits to this PR, I think we can push this with v3.3.0 so let's not wait over these things.
"I think we can push this with v3.3.0 so let's not wait over these things." is not anyone but you agreeing to ship the feature with 3.3.0.
@VishalNehra you created a tag for rc1? Won't that trigger an FDroid build?
Is there some way to get notified when a milestone's deadline changes?
Not sure... Might as well create new ones from next time.
The idea is to have a standarized way of releasing.
I propose releasing a
x.y.zrc1
first (as beta in FDroid and Play), check for bug reports and then releasex.y.zrc2
if a high priority bug appears or re-releasingx.y.zrc1
asx.y.z
(as final non-beta version) if not.