search

TeamAtomECS / AtomECS

Cold atom simulation code
GNU General Public License v3.0
46 stars 11 forks source link

Consistency of position of magnetic field #68

Open minghuaw opened 2 years ago

minghuaw commented 2 years ago

The QuadrupoleField3D and QuadrupoleField2D have their position associated with an external Position component, while PrecalculatedMagneticFieldGrid has its position defined internally. I was wondering if there is any reason for such inconsistency?

I guess this could be extended to laser beam as well because GaussianBeam also has its "position" (intersection) defined internally.

ElliotB256 commented 2 years ago

You raise a good point, it would sense to make this consistent.