search

TeamDman / PlusTiC

Minecraft mod for adding new tools to and integrating various mods with Tinkers Construct
Apache License 2.0
7 stars 15 forks source link

Mod Causes crash with the latest version of Simply Jetpacks 2 #16

Closed JesseSilv closed 3 years ago

JesseSilv commented 4 years ago

crash-2020-08-22_20.34.05-client.txt

Nanamiya738 commented 4 years ago

you use ender IO or thermal？

MasterBuilder747 commented 4 years ago

happens with me too, it looks like this new mod adds something called a pancake hippo for a jetpack? Wtf is that all about?

at landmaster.plustic.modifiers.armor.JetpackPancakeHippos.<clinit>(JetpackPancakeHippos.java:112)

tomheaton commented 4 years ago

It basically just adds jetpacks as an element/component of the custom armor that Construct's Armory adds. The pull request that I made (https://github.com/TeamDman/PlusTiC/pull/18) fixes all these issues.

DabbingEevee commented 4 years ago

appearently the jetpack mod got updated thats the problem

Moobien commented 4 years ago

"Well, the class was removed in one of the last updates, is called "KeybindHandler", I don't know why plustic is referencing my class hardcoded, but that problem has to be fixed on there end." - this is from Tomson124 regarding this issue.

tomheaton commented 4 years ago

I have the fixed code ready, will send it soon.

TeamDman commented 4 years ago

Only noticed your comment right now @Th0mas-7 if there's work that my fix doesn't address I'd love to still incorporate it

I seem to have the mod compiling again, this commit addresses the changes for getting it to work with SimplyJetpacks again

Alpha build on curseforge here https://www.curseforge.com/minecraft/mc-mods/plusticminusbad/files/3061603

I haven't been able to test it, but if others confirm that it's working I can mark it as a release

Moobien commented 4 years ago

The link to the alpha build doesn't seem to be working.

TeamDman commented 4 years ago

image Looks like it's still under review. Usually doesn't take more than a few seconds, odd that it's taking so long. Should be available soon.

TeamDman commented 4 years ago

Should be approved now

dragonman83 commented 4 years ago

I can confirm that I was able to load up without crashing after using the updated version on the client side. It looks like it's still having problems on the server side.

Moobien commented 4 years ago

ok I got a crash. Fluid Registry Corrupted. https://pastebin.com/nd43Gx7c

TeamDman commented 4 years ago

looks like stuff like applied energistics is trying to index tooltips or some crap on launch, and the way this mod was coded caused that to be an issue. @ rz7d helped identify a spot where I removed a try-catch that was previously preventing this https://github.com/TeamDman/PlusTiC/commit/4cfeb69c330da3ae448ea856e778fbd600e71bc6#r43329635

Working on some stuff now :/

TeamDman commented 4 years ago

https://www.curseforge.com/minecraft/mc-mods/plusticminusbad/files/3085037 This is the link to the latest build (if it says not found, then it's probably still awaiting approval) It should fix the issue where servers crash on launch caused by loading client classes server side. Please let me know if this does or doesn't fix the issue

HariboTer commented 3 years ago

I just tried the newest alpha build and am still getting a crash from the Simply Jetpacks 2 integration :-/ Crash report: crash-2020-12-07_03.19.27-client.txt

GreenGhost21 commented 3 years ago

I'm also still getting the Simply Jetpacks 2 crash. I would appreciate a fix as soon as is convenient.

brisingraerowing commented 3 years ago

@HariboTer You are still using the old version (according to the log file you posted). If you used the CF app, you need to go into the project page and manually select the alpha version.