TeamNewPipe / NewPipe

A libre lightweight streaming front-end for Android.
https://newpipe.net
GNU General Public License v3.0
31.71k stars 3.08k forks source link

Option to remove Shorts from the Trending Page #11562

Open Sarmadkh opened 1 month ago

Sarmadkh commented 1 month ago

Checklist

Feature description

The Trending page on the app is filled with Shorts. Like for every video, there are like 20 shorts "Trending". Can there be an option that lets you pick whether you want Shorts to appear on the trending page as well?

Why do you want this feature?

To have an option to pick if a user likes to see shorts on the trending page.

Additional information

Nil

opusforlife2 commented 1 month ago

The Youtube homepage is broken up into sections. I wonder if the kiosk can be filtered based on those.

DehaanSolo commented 1 month ago

Hi all, can I get this issue assigned to me?

AudricV commented 1 month ago

The Youtube homepage is broken up into sections. I wonder if the kiosk can be filtered based on those.

These sections are not parsed, only regular items.

@DehaanSolo I think it would be probably better to directly implement a solution like #9049. Configuring the places where shorts can be shown is also another solution.

Anyway, everything in the extractor side should be ready for all choices.

DehaanSolo commented 1 month ago

Thanks @AudricV . Is there any more work that needs to be done to implement this then? From what I can see in the app, the trending page isn't populated by shorts to the degree that this issue mentions. If not, are there any good first issues you could recommend?

Sarmadkh commented 1 month ago

the trending page isn't populated by shorts to the degree that this issue mentions.

Try switching to a South Asian country.

hanthor commented 1 month ago

What about an option to remove shorts from the Subscription page? I use NewPipe specifically to avoid Shorts, but now many channels I'm subscribed to crank tons of Shorts out.

DehaanSolo commented 1 month ago

@DehaanSolo I think it would be probably better to directly implement a solution like #9049. Configuring the places where shorts can be shown is also another solution.

Anyway, everything in the extractor side should be ready for all choices.

The two issues I've found with implementing this using StreamInfo are that the extractor currently isn't identifying whether content is short form or not - it just returns false here So, is there some sort of agreed standard as to what classifies short form content? My guess would be 60 seconds or less, but I'd like to hear thoughts from others.

The second is latency - I'm guessing there's multiple requests going on when trying to filter stream items, rather than doing some sort of check at the database Query level. If there is a standard for classifying short form content, that check could be done at the Query level in FeedDao

I tried looking into channel tabs, but couldn't find how videos were being classified and segregated into the relevant tabs.

opusforlife2 commented 1 month ago

My guess would be 60 seconds or less

Sigh. Why would YT make it that easy for us? https://blog.youtube/news-and-events/tall-updates-coming-to-shorts/

AudricV commented 1 month ago

The two issues I've found with implementing this using StreamInfo are that the extractor currently isn't identifying whether content is short form or not - it just returns false here So, is there some sort of agreed standard as to what classifies short form content? My guess would be 60 seconds or less, but I'd like to hear thoughts from others.

Nope, you looked at the wrong place. It's up to services' implementations to detect this, not the base interface. Look at implementations of the interface in the YouTube service.